Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: programmatically set agentVersion for use in identify #1296

Merged
merged 10 commits into from
Jul 15, 2022

Conversation

achingbrain
Copy link
Member

@achingbrain achingbrain commented Jul 15, 2022

If no agentVersion is provided for the Identify protocol, the default AGENT_VERSION will now be set to

  • js-libp2p/<libp2p.version> UserAgent=<process.version> when running in Node.js
  • js-libp2p/<libp2p.version> UserAgent=<navigator.userAgent> when running in the browser (also when running in a webworker)

Fixes #686
Supersedes #1240

6d7a and others added 8 commits June 10, 2022 11:59
@achingbrain achingbrain changed the title refactor(agentVersion): append user agent feat: programmatically set agentVersion for use in identify Jul 15, 2022
@achingbrain achingbrain merged commit 0bb1b80 into master Jul 15, 2022
@achingbrain achingbrain deleted the feat/add-user-agent-to-agent-version branch July 15, 2022 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Programmatically set agentVersion in Identify
2 participants