Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move error codes to @libp2p/interface/errors #2140

Closed
wants to merge 1 commit into from

Conversation

wemeetagain
Copy link
Member

Description

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if necessary (this includes comments as well)
  • I have added tests that prove my fix is effective or that my feature works

@wemeetagain wemeetagain requested a review from a team as a code owner October 9, 2023 19:16
@maschad
Copy link
Member

maschad commented Oct 9, 2023

Let's review this once #2104 is resolved.

@wemeetagain
Copy link
Member Author

wemeetagain commented Oct 9, 2023

@maschad this is needed for #2107, #1913, which is a prereq for #2104

So if we want #2107, #1913 in v1, we need this first

@maschad
Copy link
Member

maschad commented Oct 9, 2023

That's correct @wemeetagain , my apologies as I should clarify - we should resolve how we are going to synchronize all of the PRs which contain breaking changes such that they are all in released in v1 as opposed to any bug fix releases which we may need to do before v1.

We can discuss more on the Open Maintainers call on 10-10-2023

@achingbrain achingbrain changed the base branch from master to release-v1.0 October 10, 2023 11:28
@achingbrain
Copy link
Member

Is this actually breaking? Do we export these error codes?

@wemeetagain
Copy link
Member Author

Is this actually breaking? Do we export these error codes?

I guess not. Still would like to target v1 branch tho

@wemeetagain wemeetagain changed the title refactor!: move error codes to @libp2p/interface/errors refactor: move error codes to @libp2p/interface/errors Oct 10, 2023
Copy link
Member

@maschad maschad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, there just needs to be a merge conflict resolution.

@wemeetagain
Copy link
Member Author

closing this since we decided to move over error codes only one by one as needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants