Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: append peer id to connection remote addr if not present #2182

Merged
merged 2 commits into from
Nov 2, 2023

Conversation

achingbrain
Copy link
Member

If we dial an address like /ip4/123.123.123.123/tcp/123 we'll get a peer id back after the connection upgrade - append it to the remote addr to make it easier to test if we already have a connection to a given multiaddr.

Notes & open questions

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if necessary (this includes comments as well)
  • I have added tests that prove my fix is effective or that my feature works

@achingbrain achingbrain requested a review from a team as a code owner November 1, 2023 13:14
If we dial an address like `/ip4/123.123.123.123/tcp/123` we'll get
a peer id back after the connection upgrade - append it to the remote
addr to make it easier to test if we already have a connection to
a given multiaddr.
@achingbrain achingbrain force-pushed the fix/append-peer-id-to-connection-address branch from f9eca62 to c9d53bb Compare November 1, 2023 13:17
@achingbrain
Copy link
Member Author

Srsly, what is happening with the pubsub interop tests?!

@achingbrain achingbrain merged commit 3bdaad3 into master Nov 2, 2023
22 checks passed
@achingbrain achingbrain deleted the fix/append-peer-id-to-connection-address branch November 2, 2023 08:14
This was referenced Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants