fix: close early WebRTC streams properly #2200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A race condition exists where a remote can start opening streams over WebRTC before we have finished the connection upgrade. When this happens we need to be able to gracefully close the stream the same as ones opened after the upgrade. This PR makes the action taken on stream close reconfigurable after the muxer factory has been created.
achingbrain
added a commit
that referenced
this pull request
Nov 6, 2023
Fixes regession introduced by #2200
3 tasks
achingbrain
added a commit
that referenced
this pull request
Nov 6, 2023
Fixes regession introduced by #2200
This was referenced Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A race condition exists where a remote can start opening streams over WebRTC before we have finished the connection upgrade.
When this happens we need to be able to gracefully close the stream the same as ones opened after the upgrade.
This PR makes the action taken on stream close reconfigurable after the muxer factory has been created.
Change checklist