From 037817902d8305352fd3d3a804c5810cbb16faf4 Mon Sep 17 00:00:00 2001 From: Jacob Heun Date: Mon, 6 May 2019 13:14:34 +0200 Subject: [PATCH 1/3] fix: forward pubsub publish callback to floodsub chore: update floodsub version --- package.json | 2 +- src/pubsub.js | 4 +--- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/package.json b/package.json index 7c5abe162e..be542fd2ff 100644 --- a/package.json +++ b/package.json @@ -43,7 +43,7 @@ "err-code": "^1.1.2", "fsm-event": "^2.1.0", "libp2p-connection-manager": "~0.1.0", - "libp2p-floodsub": "~0.15.8", + "libp2p-floodsub": "libp2p/js-libp2p-floodsub#feat/signing", "libp2p-ping": "~0.8.5", "libp2p-switch": "~0.42.9", "libp2p-websockets": "~0.12.2", diff --git a/src/pubsub.js b/src/pubsub.js index f8dc7f9d83..0706e5d471 100644 --- a/src/pubsub.js +++ b/src/pubsub.js @@ -63,9 +63,7 @@ module.exports = (node) => { return nextTick(callback, errCode(new Error('data must be a Buffer'), 'ERR_DATA_IS_NOT_A_BUFFER')) } - floodSub.publish(topic, data) - - nextTick(() => callback()) + floodSub.publish(topic, data, callback) }, ls: (callback) => { From 6d7c65587ab8315955fd30fdb5dfb5f63873bcfe Mon Sep 17 00:00:00 2001 From: Jacob Heun Date: Mon, 6 May 2019 16:19:59 +0200 Subject: [PATCH 2/3] test: add random walk delay to config --- test/peer-discovery.node.js | 1 + 1 file changed, 1 insertion(+) diff --git a/test/peer-discovery.node.js b/test/peer-discovery.node.js index b9d4478309..d82a615a46 100644 --- a/test/peer-discovery.node.js +++ b/test/peer-discovery.node.js @@ -423,6 +423,7 @@ describe('peer discovery', () => { randomWalk: { enabled: true, queriesPerPeriod: 1, + delay: 100, interval: 200, // start the query sooner timeout: 3000 } From a406cd6efe4e2346f63422caa8d65fd55b72d720 Mon Sep 17 00:00:00 2001 From: Jacob Heun Date: Tue, 7 May 2019 12:48:28 +0200 Subject: [PATCH 3/3] chore: update floodsub --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index be542fd2ff..6d732f1874 100644 --- a/package.json +++ b/package.json @@ -43,7 +43,7 @@ "err-code": "^1.1.2", "fsm-event": "^2.1.0", "libp2p-connection-manager": "~0.1.0", - "libp2p-floodsub": "libp2p/js-libp2p-floodsub#feat/signing", + "libp2p-floodsub": "~0.16.0", "libp2p-ping": "~0.8.5", "libp2p-switch": "~0.42.9", "libp2p-websockets": "~0.12.2",