websocket wasm cannot dial /tls/ws addresses #5509
Labels
Comments
|
There was an issue that was supposed to handle this #2449. But all the comments there only consider the multiaddr library aspects of the problem and not the dialing part of the problem. Recently, this was brought up here eigerco/lumina#314 |
|
Do you mean:
rather than |
4 tasks
TimTinkers
pushed a commit
to unattended-backpack/rust-libp2p
that referenced
this issue
Sep 14, 2024
To keep backward compatibility the following rules were implemented: * On dialing, `/tls/ws` and `/wss` are equivalent. * On listening: * If user listens with `/tls/ws` then `/tls/ws` will be advertised. * If user listens with `/wss` then `/wss` will be advertised. Closes libp2p#2449 Closes libp2p#5509 Pull-Request: libp2p#5523.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Summary
Dialing
/dns/dht.nonsequitur.xyz/tcp/5123/tls/ws/p2p/12D3KooWPvLLPbUzs33TicVYPY78AEZSnd671irhqyi3UWLSBH8Hfails.Dialing
/dns/dht.nonsequitur.xyz/tcp/5123/wss/p2p/12D3KooWPvLLPbUzs33TicVYPY78AEZSnd671irhqyi3UWLSBH8Hworks fine(Edited based on: #5509 (comment)).Expected behavior
Both the dials should work.
Actual behavior
/tls/wsdials failRelevant log output
No response
Possible Solution
/tls/wsand/wssare equivalent with/wssdeprecated in favor of the more explicittls/ws. The dialing logic should consider this.Version
No response
Would you like to work on fixing this bug ?
Maybe
The text was updated successfully, but these errors were encountered: