-
Notifications
You must be signed in to change notification settings - Fork 964
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: ping tutorial using tokio #5554
Comments
Differences between the ping example and the ping tutorialCargo.toml
src/main.rs
Self-reviewed code before modifying the rust-doc tutorial: |
Solved on PR: #5559 |
github-project-automation
bot
moved this from In progress
to Done
in PLDG Cohort 0 Project Board
Aug 22, 2024
TimTinkers
pushed a commit
to unattended-backpack/rust-libp2p
that referenced
this issue
Sep 14, 2024
Solves issue libp2p#5554 also referenced first in libp2p#4449 Pull-Request: libp2p#5559.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
By identifying the missing examples and tests for solving #4449 I identified that the ping tutorial still uses async-std and there is an already refactored tokio ping example. Upon opening, there are some slight differences that might require review.
Motivation
The tokio runtime is much more well established and better maintained. Users should be able to use other runtimes or bring their own.[#4449]
Examples and tests where considered in #4449 but not this tutorial.
Current Implementation
Both runtimes are being mixed.[#4449]
Are you planning to do it yourself in a pull request ?
Yes
The text was updated successfully, but these errors were encountered: