*: Prepare v0.40.0-rc.1 release #2290

mxinden · 2021-10-14T16:21:33Z

I would like to cut a new release of:

A release candidate of all sub-crates (libp2p-XXX)
multistream-select
A release candidate of the libp2p crate - v0.40.0-rc.1

The reasoning for cutting release candidates for now, instead of a full release, is the amount of changes since the last release (see changelogs), especially #2248.

Any objections?

thomaseizinger

If #2248 is the main concern, shouldn't libp2p-core also get a RC instead of a new minor version?

mxinden · 2021-10-14T21:47:24Z

If #2248 is the main concern, shouldn't libp2p-core also get a RC instead of a new minor version?

My reasoning above was under the assumption that pretty much no one depends on any of the libp2p-XXX crates directly, but always through the main libp2p crate. Now that assumption is inconsistent with the reason why we have those sub-crates in the first place.

If #2248 is the main concern, shouldn't libp2p-core also get a RC instead of a new minor version?

Yes. Though that would imply that all other libp2p-XXX crates would need to be released as release candidates as well, as they would depend on the libp2p-core release candidate.

I need to give this more thought. Especially as this will not be the last time we cut a release candidate. I am now leaning towards cutting a release candidate of all the crates first, even though that is a bit of manual work.

More input welcome @thomaseizinger!

thomaseizinger · 2021-10-15T02:06:10Z

If #2248 is the main concern, shouldn't libp2p-core also get a RC instead of a new minor version?

Yes. Though that would imply that all other libp2p-XXX crates would need to be released as release candidates as well, as they would depend on the libp2p-core release candidate.

I need to give this more thought. Especially as this will not be the last time we cut a release candidate. I am now leaning towards cutting a release candidate of all the crates first, even though that is a bit of manual work.

I didn't think of that but that is a good point. I agree that if we want to do RCs, then doing an RC for all crates is probably the way to go.

Is a RC very different from depending on a Git revision? Perhaps we can just create an RC tag and encourage people to test with this version rather than going for all the churn of cutting a lot of RC. Even with a RC, people would have to manually update.

mxinden · 2021-10-15T09:14:47Z

rather than going for all the churn of cutting a lot of RC.

With a couple of RegExs this wasn't actually that hard. I will test out the full release candidate process via a crates release of each of the libp2p-XXX crates this time. Let's see whether it is worth it.

mxinden · 2021-10-15T10:31:35Z

I tagged and published the following releases:

libp2p-core-0.30.0-rc.1
libp2p-deflate-0.30.0-rc.1
libp2p-dns-0.30.0-rc.1
libp2p-floodsub-0.31.0-rc.1
libp2p-gossipsub-0.33.0-rc.1
libp2p-identify-0.31.0-rc.1
libp2p-kad-0.32.0-rc.1
libp2p-mdns-0.32.0-rc.1
libp2p-metrics-0.1.0-rc.1
libp2p-mplex-0.30.0-rc.1
libp2p-noise-0.33.0-rc.1
libp2p-ping-0.31.0-rc.1
libp2p-plaintext-0.30.0-rc.1
libp2p-pnet-0.22.0-rc.1
libp2p-relay-0.4.0-rc.1
libp2p-rendezvous-0.1.0-rc.1
libp2p-request-response-0.13.0-rc.1
libp2p-swarm-0.31.0-rc.1
libp2p-swarm-derive-0.25.0-rc.1
libp2p-tcp-0.30.0-rc.1
libp2p-uds-0.30.0-rc.1
libp2p-wasm-ext-0.30.0-rc.1
libp2p-websocket-0.31.0-rc.1
libp2p-yamux-0.34.0-rc.1
multistream-select-0.10.4
v0.40.0-rc.1

Downstream testing with the libp2p v0.40.0-rc.1 release candidate would be much appreciated.

@kpp do you have some time to do a burn-in on Substrate / Polkadot?
@thomaseizinger can you test this release on the Comit network stack?
@elenaf9 let me know if things run smoothly on the iotledger stack.
@ec2 let us know if this release resolves your issues with libp2p-gossipsub on Forest.
I don't think there is an additional round of testing needed for lighthouse, given that @AgeManning has already been testing core/: Concurrent connection attempts #2248 (comment).

mxinden · 2021-10-15T10:42:25Z

Also, given that this is a rather large release, I am happy to support with the upgrade process. Feel free to ping me on your upgrade pull request.

kpp · 2021-10-15T12:08:55Z

KademliaBucketInserts is not in the root of kad anymore.

mxinden · 2021-10-15T13:35:33Z

@kpp v0.40.0-rc.2 and libp2p-kad-0.32.0-rc.2 are tagged and published.

kpp · 2021-10-15T16:00:12Z

#2214 Should be somehow addressed in the https://docs.rs/libp2p/0.40.0-rc.2/libp2p/swarm/trait.NetworkBehaviour.html docs.

mxinden · 2021-10-18T10:34:53Z

#2214 Should be somehow addressed in the https://docs.rs/libp2p/0.40.0-rc.2/libp2p/swarm/trait.NetworkBehaviour.html docs.

Good point @kpp. Do you want to propose a patch?

kpp · 2021-10-18T15:04:33Z

Do you want to propose a patch?

Sorry, I am not sure what's the difference between event_process = false and true to write a doc about it.

There is no fn inject_connection_closed override for MultiHandler which is a pain when implementing NetworkBehaviour with type ProtocolsHandler = MultiHandler<...>. How do I upgrade it to a new version https://github.com/paritytech/substrate/blob/d1ec40b49847fdb6dae8f00ab7ab08cef7dd10fc/client/network/src/discovery.rs#L556 ?

thomaseizinger · 2021-10-19T20:39:36Z

Do you want to propose a patch?

Sorry, I am not sure what's the difference between event_process = false and true to write a doc about it.

The docs currently say that by default, we require NetworkBehaviour_EventProcess_. That default changed so really only the current section needs to be negated.

Sorry that I missed this as part of the PR. If none beats me to it, I'll send an update in the next couple of days!

elenaf9 · 2021-10-20T11:07:31Z

Thank you for the release @mxinden! Our upgrade went well and everything is working as expected.

mxinden · 2021-10-27T17:38:43Z

I have cut another release candidate (tagged and published) mostly due to #2304.

Let me know in case you are seeing any oddities with rc.3. If not, I would promote the release candidate to a proper release in the next couple of days. (//CC @AgeManning)

The default behaviour changed with libp2p#2214. This updates the doc comment. Initially raised in libp2p#2290 (comment).

mxinden · 2021-10-29T17:41:04Z

There is no fn inject_connection_closed override for MultiHandler which is a pain when implementing NetworkBehaviour with type ProtocolsHandler = MultiHandler<...>. How do I upgrade it to a new version https://github.com/paritytech/substrate/blob/d1ec40b49847fdb6dae8f00ab7ab08cef7dd10fc/client/network/src/discovery.rs#L556 ?

I am a bit confused. MultiHandler does not implement NetworkBehaviour in the first place and thus also doesn't implement inject_connection_closed @kpp.

The default behaviour changed with #2214. This updates the doc comment. Initially raised in #2290 (comment).

mxinden · 2021-10-30T09:30:47Z

I just branched off of master with v0.40, where further release candidates or the final release will be cut off of.

With that, master will now track the next (upcoming) release line, v0.41.

mxinden · 2021-11-01T11:15:38Z

For the record v0.40.0 is tagged and published #2323.

The default behaviour changed with libp2p/rust-libp2p#2214. This updates the doc comment. Initially raised in libp2p/rust-libp2p#2290 (comment).

*: Prepare v0.40.0-rc.1 release

1b874d2

mxinden requested a review from thomaseizinger October 14, 2021 16:21

thomaseizinger reviewed Oct 14, 2021

View reviewed changes

*: Prepare release candidate of all libp2p-XXX crates

5b73d85

mxinden merged commit a905665 into libp2p:master Oct 15, 2021

mxinden mentioned this pull request Oct 15, 2021

Can we get a new version pushed to crates.io please? #2273

Closed

mxinden mentioned this pull request Oct 15, 2021

protocols/kad: Export KademliaBucketInserts #2294

Merged

mxinden mentioned this pull request Oct 20, 2021

swarm/src/lib: Continue polling network when behaviour is blocked #2304

Merged

elenaf9 mentioned this pull request Oct 22, 2021

Patch libp2p dependency to v0.40.0-rc.2 iotaledger/stronghold.rs#271

Merged

mxinden added a commit to mxinden/rust-libp2p that referenced this pull request Oct 29, 2021

swarm/src/behaviour: Fix outdated comment on derive's out_event

d9a76e7

The default behaviour changed with libp2p#2214. This updates the doc comment. Initially raised in libp2p#2290 (comment).

mxinden mentioned this pull request Oct 29, 2021

swarm/src/behaviour: Fix outdated comment on derive's out_event #2318

Merged

mxinden added a commit that referenced this pull request Oct 30, 2021

swarm/src/behaviour: Fix outdated comment on derive's out_event (#2318)

997cc9a

The default behaviour changed with #2214. This updates the doc comment. Initially raised in #2290 (comment).

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

*: Prepare v0.40.0-rc.1 release #2290

*: Prepare v0.40.0-rc.1 release #2290

mxinden commented Oct 14, 2021 •

edited

Loading

thomaseizinger left a comment

mxinden commented Oct 14, 2021

thomaseizinger commented Oct 15, 2021

mxinden commented Oct 15, 2021

mxinden commented Oct 15, 2021

mxinden commented Oct 15, 2021

kpp commented Oct 15, 2021

mxinden commented Oct 15, 2021

kpp commented Oct 15, 2021

mxinden commented Oct 18, 2021

kpp commented Oct 18, 2021 •

edited

Loading

thomaseizinger commented Oct 19, 2021

elenaf9 commented Oct 20, 2021

mxinden commented Oct 27, 2021

mxinden commented Oct 29, 2021

mxinden commented Oct 30, 2021

mxinden commented Nov 1, 2021

*: Prepare v0.40.0-rc.1 release #2290

*: Prepare v0.40.0-rc.1 release #2290

Conversation

mxinden commented Oct 14, 2021 • edited Loading

thomaseizinger left a comment

Choose a reason for hiding this comment

mxinden commented Oct 14, 2021

thomaseizinger commented Oct 15, 2021

mxinden commented Oct 15, 2021

mxinden commented Oct 15, 2021

mxinden commented Oct 15, 2021

kpp commented Oct 15, 2021

mxinden commented Oct 15, 2021

kpp commented Oct 15, 2021

mxinden commented Oct 18, 2021

kpp commented Oct 18, 2021 • edited Loading

thomaseizinger commented Oct 19, 2021

elenaf9 commented Oct 20, 2021

mxinden commented Oct 27, 2021

mxinden commented Oct 29, 2021

mxinden commented Oct 30, 2021

mxinden commented Nov 1, 2021

mxinden commented Oct 14, 2021 •

edited

Loading

kpp commented Oct 18, 2021 •

edited

Loading