Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.github/ISSUE_TEMPLATE: fix config.yml file name #2633

Merged
merged 3 commits into from
May 6, 2022

Conversation

elenaf9
Copy link
Contributor

@elenaf9 elenaf9 commented May 4, 2022

Description

Addendum to #2611:

  • Fix typo in file name .github/ISSUE_TEMPLATE/config.yaml -> .github/ISSUE_TEMPLATE/config.yml
  • Add note to the bug-report template that a logger implementation needs to be initialized in order for the logging to work.

@elenaf9 elenaf9 changed the title Patch/issue templates .github/ISSUE_TEMPLATE: fix config.yml file name May 4, 2022
Copy link
Member

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bummer that whether one uses yaml or yml actually matters.

Thanks for the fix!

@@ -23,6 +23,8 @@ Please provide a short summary of the bug, along with any information you feel r

<!--
Include debug output in the code block by setting `RUST_LOG=debug` in your environment.
Note that for this a logger implementation needs to be initialized in the program, e.g. with
`env_logger::init()`. See <https://docs.rs/log> for more info.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@mxinden mxinden merged commit 9c7861f into libp2p:master May 6, 2022
@elenaf9 elenaf9 deleted the patch/issue-templates branch May 6, 2022 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants