Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(examples): change chat from async-std to tokio #4539

Merged
merged 5 commits into from
Sep 23, 2023
Merged

refactor(examples): change chat from async-std to tokio #4539

merged 5 commits into from
Sep 23, 2023

Conversation

randommm
Copy link
Contributor

@randommm randommm commented Sep 21, 2023 •
edited by thomaseizinger
Loading

Description

Related: #4449.

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

@randommm randommm changed the title switch example chat from std-async to tokio refactor(examples): switch example chat from std-async to tokio Sep 21, 2023
thomaseizinger
thomaseizinger approved these changes Sep 21, 2023
View reviewed changes
Copy link
Contributor

@thomaseizinger thomaseizinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you!

Just two minor things :)

examples/chat/Cargo.toml Outdated Show resolved Hide resolved
examples/chat/src/main.rs Outdated Show resolved Hide resolved
@thomaseizinger thomaseizinger changed the title refactor(examples): switch example chat from std-async to tokio refactor(examples): change chat from async-std to tokio Sep 21, 2023
thomaseizinger
thomaseizinger approved these changes Sep 23, 2023
View reviewed changes
Copy link
Contributor

@thomaseizinger thomaseizinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you!

@mergify mergify bot merged commit b4d9e52 into libp2p:master Sep 23, 2023
73 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomaseizinger thomaseizinger thomaseizinger approved these changes

Assignees
No one assigned
Labels
send-it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@randommm @thomaseizinger