Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor libremesh.mk and makefiles #829

Merged
merged 2 commits into from
Jan 12, 2021

Conversation

spiccinini
Copy link
Contributor

@spiccinini spiccinini commented Dec 15, 2020

The idea is to be able to use libremesh.mk like a module so that it can be more easily customized.

I still have to test a full build with this, but want to share the idea to get feedback.

Fixes #825

@codecov-io
Copy link

codecov-io commented Dec 16, 2020

Codecov Report

Merging #829 (f262998) into master (19cc376) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #829   +/-   ##
=======================================
  Coverage   72.27%   72.27%           
=======================================
  Files          37       37           
  Lines        3293     3293           
=======================================
  Hits         2380     2380           
  Misses        913      913           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19cc376...f262998. Read the comment docs.

@G10h4ck
Copy link
Member

G10h4ck commented Dec 17, 2020

This looks much better to me!

@spiccinini
Copy link
Contributor Author

Ok so I've built an image with this changes, so far so good.

@spiccinini
Copy link
Contributor Author

Ping! @ilario what do you think?

@ilario
Copy link
Member

ilario commented Jan 8, 2021

Did not test, looks working to me

@spiccinini spiccinini merged commit 0dbbc8a into libremesh:master Jan 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Errors in eupgrade Makefile
4 participants