Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ready for RetroArch 1.19.2] udev: Remove Sony-PlayStation4-DualShock4-Controller.cfg -- Merge DualShock v1 and v2 in #1168 #1190

Closed
wants to merge 2 commits into from

Conversation

@davidhedlund davidhedlund changed the title udev: Rename Sony-PlayStation4-DualShock4-Controller.cfg to Sony Computer Entertainment Wireless Controller.cfg [READY] udev: Rename Sony-PlayStation4-DualShock4-Controller.cfg to Sony Computer Entertainment Wireless Controller.cfg Sep 12, 2024
@davidhedlund davidhedlund changed the title [READY] udev: Rename Sony-PlayStation4-DualShock4-Controller.cfg to Sony Computer Entertainment Wireless Controller.cfg [READY] udev: Rename Sony-PlayStation4-DualShock4-Controller.cfg to Sony Computer Entertainment Wireless Controller.cfg Sep 12, 2024
@davidhedlund davidhedlund changed the title [READY] udev: Rename Sony-PlayStation4-DualShock4-Controller.cfg to Sony Computer Entertainment Wireless Controller.cfg [READY] udev: Merge Sony-PlayStation4-DualShock4-Controller.cfg Sep 12, 2024
@davidhedlund davidhedlund changed the title [READY] udev: Merge Sony-PlayStation4-DualShock4-Controller.cfg [READY] udev: Remove Sony-PlayStation4-DualShock4-Controller.cfg -- Merged DualShock v1 and v2 in #1168 Sep 13, 2024
@davidhedlund davidhedlund changed the title [READY] udev: Remove Sony-PlayStation4-DualShock4-Controller.cfg -- Merged DualShock v1 and v2 in #1168 [READY] udev: Remove Sony-PlayStation4-DualShock4-Controller.cfg -- Merge DualShock v1 and v2 in #1168 Sep 13, 2024
Copy link
Member

@RobLoach RobLoach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could likely merge this PR with the others relating to PlayStation4

@cmitu
Copy link
Contributor

cmitu commented Oct 1, 2024

IMHO this PR - and the other similar ones that delete profiles - shouldn't be merged until at least one RetroArch release is made. Right now there's no release including libretro/RetroArch#16990, the change which makes this PR possible.
Also, if users don't have the last RetroArch version and update their controller profiles can potentially lose the profile they use, since their RetroArch version doesn't implement the profile matching from libretro/RetroArch#16990.

@davidhedlund davidhedlund changed the title [READY] udev: Remove Sony-PlayStation4-DualShock4-Controller.cfg -- Merge DualShock v1 and v2 in #1168 [READY for RetroArch 1.19.2] udev: Remove Sony-PlayStation4-DualShock4-Controller.cfg -- Merge DualShock v1 and v2 in #1168 Oct 1, 2024
@davidhedlund davidhedlund changed the title [READY for RetroArch 1.19.2] udev: Remove Sony-PlayStation4-DualShock4-Controller.cfg -- Merge DualShock v1 and v2 in #1168 [Ready for RetroArch 1.19.2] udev: Remove Sony-PlayStation4-DualShock4-Controller.cfg -- Merge DualShock v1 and v2 in #1168 Oct 1, 2024
@davidhedlund
Copy link
Contributor Author

IMHO this PR - and the other similar ones that delete profiles - shouldn't be merged until at least one RetroArch release is made. Right now there's no release including libretro/RetroArch#16990, the change which makes this PR possible. Also, if users don't have the last RetroArch version and update their controller profiles can potentially lose the profile they use, since their RetroArch version doesn't implement the profile matching from libretro/RetroArch#16990.

I replaced "[READY]" with "[Ready for RetroArch 1.19.2]" in the titles for these PRs.

@davidhedlund
Copy link
Contributor Author

Could likely merge this PR with the others relating to PlayStation4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants