Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WRN-13. An event is omitted #394

Closed
arwer13 opened this issue Jan 19, 2022 · 0 comments
Closed

WRN-13. An event is omitted #394

arwer13 opened this issue Jan 19, 2022 · 0 comments
Labels
audit Issue comes as a result of an external audit solidity issues/tasks related to smart contract code

Comments

@arwer13
Copy link
Contributor

arwer13 commented Jan 19, 2022 •
edited
Loading

There are omitted events at the lines:

  1. On depositing buffered ether
    https://github.com/lidofinance/lido-dao/blob/5b449b740cddfbef5c107505677e6a576e2c2b69/contracts/0.8.9/DepositSecurityModule.sol#L425

  2. On positive beacon rewards during handling oracle report
    https://github.com/lidofinance/lido-dao/blob/5b449b740cddfbef5c107505677e6a576e2c2b69/contracts/0.4.24/Lido.sol#L283

  3. On _setDepositContract
    https://github.com/lidofinance/lido-dao/blob/5b449b740cddfbef5c107505677e6a576e2c2b69/contracts/0.4.24/Lido.sol#L406

  4. On _setOracle
    https://github.com/lidofinance/lido-dao/blob/5b449b740cddfbef5c107505677e6a576e2c2b69/contracts/0.4.24/Lido.sol#L415

  5. On _setOperators (node operators registry)
    https://github.com/lidofinance/lido-dao/blob/5b449b740cddfbef5c107505677e6a576e2c2b69/contracts/0.4.24/Lido.sol#L424

  6. On _setTreasury
    https://github.com/lidofinance/lido-dao/blob/5b449b740cddfbef5c107505677e6a576e2c2b69/contracts/0.4.24/Lido.sol#L429

  7. On _setInsuranceFund
    https://github.com/lidofinance/lido-dao/blob/5b449b740cddfbef5c107505677e6a576e2c2b69/contracts/0.4.24/Lido.sol#L434

  8. On staking to official DepositContract
    https://github.com/lidofinance/lido-dao/blob/5b449b740cddfbef5c107505677e6a576e2c2b69/contracts/0.4.24/Lido.sol#L546

  9. On _setBPValue
    https://github.com/lidofinance/lido-dao/blob/5b449b740cddfbef5c107505677e6a576e2c2b69/contracts/0.4.24/Lido.sol#L656
@arwer13 arwer13 linked a pull request Jan 20, 2022 that will close this issue
Audit/deposit security module #393
Closed
@arwer13 arwer13 added audit Issue comes as a result of an external audit solidity issues/tasks related to smart contract code labels Jan 20, 2022
@arwer13 arwer13 closed this as completed May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
audit Issue comes as a result of an external audit solidity issues/tasks related to smart contract code
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Audit/deposit security module lidofinance/core
1 participant
@arwer13