Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new Rust port to Other APIs section #621

Merged
merged 1 commit into from
Mar 8, 2019
Merged

add new Rust port to Other APIs section #621

merged 1 commit into from
Mar 8, 2019

Conversation

mockersf
Copy link
Contributor

@mockersf mockersf commented Mar 8, 2019

I just finished my Rust port of the HOCON specifications and would like to have it mentioned in the README.
To help my tests, I also created https://github.com/mockersf/hocon-test-suite which is a small set of reference HOCON files and how they would render as JSON to be able to compare my results with the official API. I think it would be great to have something similar officially.

@lightbend-cla-validator
Copy link
Collaborator

Hi @mockersf,

Thank you for your contribution! We really value the time you've taken to put this together.

Before we proceed with reviewing this pull request, please sign the Lightbend Contributors License Agreement:

http://www.lightbend.com/contribute/cla

@mockersf
Copy link
Contributor Author

mockersf commented Mar 8, 2019

I signed the CLA

Copy link
Collaborator

@havocp havocp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! And yes, I'd love to have a language-independent tck like that. 👍 If it were in this main repo, I think it'd be important to make it run along with the other automated tests, so it wouldn't bit-rot.

@havocp
Copy link
Collaborator

havocp commented Mar 8, 2019

There's a fix for the CI failure in #620 so I'll merge this

@havocp havocp merged commit 64c60f0 into lightbend:master Mar 8, 2019
@2m 2m added this to the 1.3.4 milestone Apr 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants