f! take events by value

Author: wpaulino

lightning-invoice/src/payment.rs

@@ -52,6 +52,9 @@
 //! # struct FakeEventProvider {}
 //! # impl EventsProvider for FakeEventProvider {
 //! #     fn process_pending_events<H: Deref>(&self, handler: H) where H::Target: EventHandler {}
+//! #     fn process_pending_events_async<'a, H: Deref + 'a>(
+//! #         &'a self, handler: H
+//! #     ) -> Pin<Box<dyn StdFuture<Output = ()> + 'a>> where H::Target: AsyncEventHandler {}
 //! # }
 //! #
 //! # struct FakePayer {}

lightning/src/chain/chainmonitor.rs

@@ -763,7 +763,7 @@ impl<ChannelSigner: Sign, C: Deref, T: Deref, F: Deref, L: Deref, P: Deref> even
 				pending_events.append(&mut monitor_state.monitor.get_and_clear_pending_events());
 			}
 			for event in pending_events.drain(..) {
-				handler.handle_event_async(&event).await;
+				handler.handle_event_async(event).await;
 			}
 		})
     }

lightning/src/ln/channelmanager.rs

@@ -5669,7 +5669,7 @@ where
 			}
 
 			for event in pending_events.drain(..) {
-				handler.handle_event_async(&event).await;
+				handler.handle_event_async(event).await;
 			}
 
 			if result == NotifyOption::DoPersist {

lightning/src/util/events.rs

@@ -1407,19 +1407,19 @@ pub trait AsyncEventHandler {
 	/// Handles the given [`Event`] asynchronously.
 	///
 	/// See [`EventsProvider`] for details that must be considered when implementing this method.
-	fn handle_event_async<'a>(&'a self, event: &'a Event) -> Pin<Box<dyn StdFuture<Output = ()> + 'a>>;
+	fn handle_event_async<'a>(&'a self, event: Event) -> Pin<Box<dyn StdFuture<Output = ()> + 'a>>;
 }
 
-impl<F> AsyncEventHandler for F where F: Fn(&Event) {
-	fn handle_event_async<'a>(&'a self, event: &'a Event) -> Pin<Box<dyn StdFuture<Output = ()> + 'a>> {
+impl<F> AsyncEventHandler for F where F: Fn(Event) {
+	fn handle_event_async<'a>(&'a self, event: Event) -> Pin<Box<dyn StdFuture<Output = ()> + 'a>> {
 		Box::pin(async move {
 			self(event);
 		})
 	}
 }
 
 impl<T: AsyncEventHandler> AsyncEventHandler for Arc<T> {
-	fn handle_event_async<'a>(&'a self, event: &'a Event) -> Pin<Box<dyn StdFuture<Output = ()> + 'a>> {
+	fn handle_event_async<'a>(&'a self, event: Event) -> Pin<Box<dyn StdFuture<Output = ()> + 'a>> {
 		Box::pin(async move {
 			self.deref().handle_event_async(event).await
 		})