-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump lightning-terminal for wasm-client & mobile #82
Merged
ellemouton
merged 3 commits into
lightninglabs:master
from
ViktorTigerstrom:2023-08-bump-dependencies
Aug 18, 2023
Merged
bump lightning-terminal for wasm-client & mobile #82
ellemouton
merged 3 commits into
lightninglabs:master
from
ViktorTigerstrom:2023-08-bump-dependencies
Aug 18, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ViktorTigerstrom
force-pushed
the
2023-08-bump-dependencies
branch
2 times, most recently
from
August 16, 2023 08:49
0094c09
to
59710a3
Compare
jamaljsr
approved these changes
Aug 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK LGTM 🚀
LGTM! |
jbrill
approved these changes
Aug 16, 2023
guggero
approved these changes
Aug 17, 2023
Bump the lightning-terminal dependency for the wasm-client to `v0.10.5-alpha`. Also bump lnd to `v0.16.4-beta`, taproot-assets to `v0.2.3`, loop to `v0.26.2-beta` and grpc to `v1.53.0` as it's required with the lightning-terminal bump. Also bump the lightning-node-connect dependency to `v0.2.4-alpha`, but as this dependency is replaced, this doesn't have any real effect.
Remove the direct dependency on github.com/golang/protobuf and use google.golang.org/protobuf for mobile instead, as the former is deprecated.
Bump the lightning-terminal dependency for mobile to `v0.10.5-alpha`. Also bump lnd to `v0.16.4-beta` and grpc to `v1.53.0` as it's required with the lightning-terminal bump. Also bump the lightning-node-connect dependency to `v0.2.4-alpha`, but as this dependency is replaced, this doesn't have any real effect.
ViktorTigerstrom
force-pushed
the
2023-08-bump-dependencies
branch
from
August 17, 2023 23:17
59710a3
to
ae29c6a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR bumps the lightning-terminal version for the wasm-client and mobile to
v0.10.5-alpha
.Happy to address any feedback :)!