Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Horizon v1.0.0 Compatibility #265

Merged

Conversation

overcat
Copy link
Member

@overcat overcat commented Feb 5, 2020

#261

  • feat: add support for /offers end-point with query parameters.
  • feat: add support for /accounts end-point with ?signer and ?asset filters.

@ire-and-curses
Copy link

Tamir is out for a week now. @leighmcculloch do you think you could take a look at this?

@leighmcculloch
Copy link
Contributor

@ire-and-curses Apologies this fell through my notifications. I don't have much context on what it means to be Horizon v1 compatible and my queue is pretty deep right now so I'm unlikely to get to this PR before @tamirms returns. Let me know if there is particular urgency here I am not aware of.

@leighmcculloch leighmcculloch removed their request for review February 14, 2020 18:10
@tamirms tamirms changed the base branch from master to release-0.14.0 February 19, 2020 17:36
@overcat
Copy link
Member Author

overcat commented Feb 20, 2020

It is worth mentioning that in horizon 1.0, the offer_id in the offers endpoint is a string type, but in Java code we will parse it into a Long type. Do you think we need to change it? I read the horizon code and it is still of int64 at the bottom, so I don't think we need to modify it.

Let's put all type-related changes in another PR.

@overcat overcat requested a review from tamirms February 20, 2020 11:22
Copy link
Contributor

@tamirms tamirms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@overcat this looks great! we should keep offerId as a long as you've noted

@tamirms tamirms merged commit e461cd5 into lightsail-network:release-0.14.0 Feb 24, 2020
@overcat overcat deleted the dev-horizon-v1.0 branch August 11, 2023 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants