-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Horizon v1.0.0 Compatibility #265
Horizon v1.0.0 Compatibility #265
Conversation
a038719
to
1a200dd
Compare
Tamir is out for a week now. @leighmcculloch do you think you could take a look at this? |
@ire-and-curses Apologies this fell through my notifications. I don't have much context on what it means to be Horizon v1 compatible and my queue is pretty deep right now so I'm unlikely to get to this PR before @tamirms returns. Let me know if there is particular urgency here I am not aware of. |
4682ea8
to
0c54660
Compare
src/test/java/org/stellar/sdk/requests/AccountsRequestBuilderTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/stellar/sdk/requests/OffersRequestBuilderTest.java
Outdated
Show resolved
Hide resolved
It is worth mentioning that in horizon 1.0, the Let's put all type-related changes in another PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@overcat this looks great! we should keep offerId as a long as you've noted
#261
/offers
end-point with query parameters./accounts
end-point with ?signer and ?asset filters.