Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was running into an odd timing issue when using the
closeByNavigation
option alongsideangular-ui-router
package.Reproduce:
Problem:
The second time that you entered the route the
$locationChangeSuccess
would fire after the controller loads which then forces the dialog to close.Solution:
Added detection into ngdialog for
$stateChangeSuccess
as that fires consistently with controller instantiation through resolves.Demo
Current ngDialog
http://s.codepen.io/jdelibas/debug/KpeXmr
PR #227 ngDialog
http://s.codepen.io/jdelibas/debug/aOKLyO