-
Notifications
You must be signed in to change notification settings - Fork 70
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
vendor packaging.version for our own use
because LegacyVersion is deprecated. closes #180.
- Loading branch information
Showing
4 changed files
with
636 additions
and
6 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1,4 @@ | ||
This directory contains modules from my [winterpy](https://github.com/lilydjwg/winterpy). | ||
This directory contains code from other places: | ||
|
||
* `nicelogger.py`: from my [winterpy](https://github.com/lilydjwg/winterpy) | ||
* `packaging_version.py`: from python-packaging 20.9, modified |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +0,0 @@ | ||
# MIT licensed | ||
# Copyright (c) 2020 lilydjwg <lilydjwg@gmail.com>, et al. | ||
|
||
Oops, something went wrong.
606b3f6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, could you also update
docs/usage.rst
? That file mentionspkg_resource.parse_version
, while after the removal ofLegacyVersion
[1], the behavior of that function will be different from the one in nvchecker.[1] pypa/packaging#407
606b3f6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've updated that so people know there are no longer the same.