vz: create vz-identifier on limactl create, not on limactl start

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>

Author: AkihiroSuda

pkg/driver/driver.go

@@ -16,6 +16,14 @@ type Driver interface {
 	// Validate returns error if the current driver isn't support for given config
 	Validate() error
 
+	// Initialize is called on creating the instance for initialization.
+	// (e.g., creating "vz-identifier" file)
+	//
+	// Initialize must not return a non-nil error when it is called against an existing instance.
+	//
+	// Initialize does not create the disks.
+	Initialize(_ context.Context) error
+
 	// CreateDisk returns error if the current driver fails in creating disk
 	CreateDisk() error
 
@@ -69,6 +77,10 @@ func (d *BaseDriver) Validate() error {
 	return nil
 }
 
+func (d *BaseDriver) Initialize(_ context.Context) error {
+	return nil
+}
+
 func (d *BaseDriver) CreateDisk() error {
 	return nil
 }

pkg/start/start.go

@@ -72,7 +72,7 @@ type Prepared struct {
 }
 
 // Prepare ensures the disk, the nerdctl archive, etc.
-func Prepare(_ context.Context, inst *store.Instance) (*Prepared, error) {
+func Prepare(ctx context.Context, inst *store.Instance) (*Prepared, error) {
 	y, err := inst.LoadYAML()
 	if err != nil {
 		return nil, err
@@ -87,6 +87,10 @@ func Prepare(_ context.Context, inst *store.Instance) (*Prepared, error) {
 		return nil, err
 	}
 
+	if err := limaDriver.Initialize(ctx); err != nil {
+		return nil, err
+	}
+
 	// Check if the instance has been created (the base disk already exists)
 	created := false
 	baseDisk := filepath.Join(inst.Dir, filenames.BaseDisk)

pkg/vz/vz_driver_darwin.go

@@ -130,6 +130,11 @@ func (l *LimaVzDriver) Validate() error {
 	return nil
 }
 
+func (l *LimaVzDriver) Initialize(_ context.Context) error {
+	_, err := getMachineIdentifier(l.BaseDriver)
+	return err
+}
+
 func (l *LimaVzDriver) CreateDisk() error {
 	return EnsureDisk(l.BaseDriver)
 }