CI: redundant go test on Windows
#3822
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Oleksandr Redko <oleksandr.red+github@gmail.com>
jandubois
approved these changes
Aug 13, 2025
Member
jandubois
left a comment
jandubois
left a comment
There was a problem hiding this comment.
Thanks, LGTM
Maybe should have a comment, to avoid somebody else adding it back in the future. 😄
Member
Author
I propose to refactor workflows by moving all unit tests to a separate job. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that
go test -v ./...runs twice onwindows-2025:lima/.github/workflows/test.yml
Line 197 in 170824e
lima/.github/workflows/test.yml
Line 228 in 170824e
We can remove one.