refactor(wasm): specify wasm event types #254
Merged
+62
−38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #254 +/- ##
=======================================
Coverage ? 53.31%
=======================================
Files ? 639
Lines ? 46954
Branches ? 0
=======================================
Hits ? 25035
Misses ? 19071
Partials ? 2848 |
whylee259
reviewed
Jun 24, 2021
- Change wasm(AttributesKeySigner) to common(AttributesKeySender) - Remove duplicated the AttributeKeyContract in EventTypeUpdateContractStatus and EventTypeMessage
brew0722
changed the title
whylee259
reviewed
Jun 24, 2021
whylee259
reviewed
Jun 24, 2021
whylee259
reviewed
Jun 24, 2021
added 3 commits
June 24, 2021 16:42
It will be merged one event when calling StringEvents.Flatten()
no need common event, because it is not executed by msg.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #146, CosmWasm/wasmd#440
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes