-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix bugs on aborting x/foundation proposals #687
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #687 +/- ##
==========================================
+ Coverage 61.01% 61.04% +0.03%
==========================================
Files 873 873
Lines 98429 98429
==========================================
+ Hits 60054 60090 +36
+ Misses 34787 34740 -47
- Partials 3588 3599 +11
|
0Tech
force-pushed
the
foundation_fix
branch
from
September 29, 2022 04:43
5e06b60
to
f3a5dda
Compare
zemyblue
reviewed
Oct 4, 2022
dudong2
approved these changes
Oct 4, 2022
zemyblue
approved these changes
Oct 4, 2022
5 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This patch will fix the stopping logic in the iteration of the
abortOldProposals()
, and add the corresponding unit test.It also fixes the misleading variable names of proposal in the test.
Motivation and context
It didn't update the state of the latest proposals (to aborted), if there are proposals of multiple foundation versions.
Checklist:
CHANGELOG.md
client/docs/swagger-ui/swagger.yaml