Missing Amino Codec Registration #736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-sdk #11224) * fix: Add RegisterLegacyAminoCodec for authz/feegrant * add module name * Fix GetSignByes, add tests * removed module names from registered messages to match other modules * added interfaces and concrete types registration * unseal amino instances to allow external grant and authorization registration * fixed messages tests * allow to register external types into authz modulecdc * use legacy.Cdc instead of ModuleCdc inside x/authz * move the legacy.Cdc initialization outside init function * added serialization docs * Update docs/core/encoding.md Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com> * added the Ledger specification * fixed tests Co-authored-by: Amaury M <1293565+amaurym@users.noreply.github.com>
Signed-off-by: zemyblue <zemyblue@gmail.com>
…240) Signed-off-by: zemyblue <zemyblue@gmail.com>
…cosmos-sdk #11349)
…11680) Signed-off-by: zemyblue <zemyblue@gmail.com>
Signed-off-by: zemyblue <zemyblue@gmail.com>
|
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #736 +/- ##
==========================================
+ Coverage 61.95% 62.02% +0.06%
==========================================
Files 875 877 +2
Lines 98798 98890 +92
==========================================
+ Hits 61210 61334 +124
+ Misses 33985 33942 -43
- Partials 3603 3614 +11
|
Signed-off-by: zemyblue <zemyblue@gmail.com>
|
|
Thank you for notify to me. I'll apply it as next PR. |
ulbqb
approved these changes
Oct 19, 2022
5 tasks
4 tasks
3 tasks
96 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR applys the missing amino codec registration PRs of cosmos-sdk.
I'll add
token,collectionandfoundationamino codec as another pr.related: #735
I want to merge this PR as
commit mergestyle, since this sub pr is cosmos-sdk pr and we need to keep the commit history.Motivation and context
How has this been tested?
Screenshots (if appropriate):
Checklist:
CHANGELOG.mdclient/docs/swagger-ui/swagger.yaml