-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add unhandled return error handling. #782
fix: add unhandled return error handling. #782
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## rc9/v0.46.0 #782 +/- ##
===============================================
- Coverage 62.19% 62.13% -0.06%
===============================================
Files 880 880
Lines 99479 99488 +9
===============================================
- Hits 61868 61815 -53
- Misses 33994 34065 +71
+ Partials 3617 3608 -9
|
Signed-off-by: zemyblue <zemyblue@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: zemyblue <zemyblue@gmail.com>
Signed-off-by: zemyblue <zemyblue@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
;)
Co-authored-by: Youngtaek Yoon <noreply@yoon.anonaddy.me>
In this PR, most error handling codes can't do unittest. So I'll skip the codecov error of ci in this case. |
Description
Add unhandled return error handling.
Motivation and context
How has this been tested?
Screenshots (if appropriate):
Checklist:
CHANGELOG.md
client/docs/swagger-ui/swagger.yaml