Skip to content

add sender into each sendMessage class #381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 22, 2022
Merged

add sender into each sendMessage class #381

merged 2 commits into from
Apr 22, 2022

Conversation

@rotoyang
Copy link
Contributor

@rotoyang rotoyang commented Apr 20, 2022

Based on the #247, add sender into each sendMassage class.

@CLAassistant
Copy link

CLAassistant commented Apr 20, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

louis70109
louis70109 approved these changes Apr 21, 2022
View reviewed changes
Copy link
Member

@louis70109 louis70109 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@louis70109
Copy link
Member

louis70109 commented Apr 21, 2022

@rotoyang Cloud you please fix CI error?

linebot/models/send_messages.py:146:100: E501 line too long (106 > 99 characters)

@rotoyang
Copy link
Contributor Author

rotoyang commented Apr 21, 2022

@rotoyang Cloud you please fix CI error?

linebot/models/send_messages.py:146💯 E501 line too long (106 > 99 characters)

@louis70109 Thx for review. Ci error fixed.

@louis70109 louis70109 merged commit 3f28675 into line:master Apr 22, 2022
@louis70109
Copy link
Member

louis70109 commented Apr 22, 2022

Thanks @rotoyang contribution :)

louis70109 added a commit that referenced this pull request Jun 9, 2022
@louis70109
Release 2.3.0
37eb413 
- Add two parameters to PostbackAction (#386)  @nanato12 
- Support : "webhook redelivery" (#385) @nanato12 
- add sender into each sendMessage class (#381)  @rotoyang 
- Drop python 3.6 support, start python 3.10 support. Close #366 (#379) @tokuhirom
@louis70109 louis70109 mentioned this pull request Jun 9, 2022
Merged
louis70109 added a commit that referenced this pull request Jun 15, 2022
@louis70109
Release 2.3.0 (#388)
842b8ab 
- Add two parameters to PostbackAction (#386)  @nanato12 
- Support : "webhook redelivery" (#385) @nanato12 
- add sender into each sendMessage class (#381)  @rotoyang 
- Drop python 3.6 support, start python 3.10 support. Close #366 (#379) @tokuhirom
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@louis70109 louis70109 louis70109 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rotoyang @CLAassistant @louis70109