Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: split js / jsx macro #86

Merged
merged 1 commit into from
Apr 5, 2024
Merged

Conversation

timofei-iatsenko
Copy link
Collaborator

port: lingui/js-lingui#1883

closes: #85

@andrii-bodnar andrii-bodnar linked an issue Mar 29, 2024 that may be closed by this pull request
@andrii-bodnar andrii-bodnar merged commit d00c6a7 into next Apr 5, 2024
@andrii-bodnar andrii-bodnar deleted the fearure/split-js-jsx-macro branch April 5, 2024 09:30
@yunsii
Copy link

yunsii commented Jul 12, 2024

image

It still not work with @lingui/swc-plugin@5.0.0-next.0, commit: yunsii/lingui-examples-nextjs-swc-1797@5573547

@timofei-iatsenko
Copy link
Collaborator Author

But this is a diffrent issue, looks like a version misalignment between next-swc/swc core version and lingui plugin version.

@yunsii
Copy link

yunsii commented Jul 12, 2024

We are still use next 13.4.12, is it possible to support it?

@timofei-iatsenko
Copy link
Collaborator Author

this is an upstream issue, swc plugins doesn't have a semver compatibility. We could not publish changes to the plugin using previous version of swc-core. But you can compile plugin with whatever version of swc-core you need and store wasm binary in your repo. There is a comprehensive manual how to do that in plugin's contribution guide.

@yunsii
Copy link

yunsii commented Jul 15, 2024

Thanks, I will try it later.

@Yidoon
Copy link

Yidoon commented Jul 16, 2024

this is an upstream issue, swc plugins doesn't have a semver compatibility. We could not publish changes to the plugin using previous version of swc-core. But you can compile plugin with whatever version of swc-core you need and store wasm binary in your repo. There is a comprehensive manual how to do that in plugin's contribution guide.

It doesn't work :( , I replace the swc_core version to 0.79.28 , but get a lot of erros when I run cargo build-wasi --release.👇
image

this is rust show command result in my device
image

see this commit(I just replace the swc-core version from 0.90.35 to 0.79.28 in the Cargo.toml file): swc-core version

@timofei-iatsenko
Copy link
Collaborator Author

Because there are breaking changes between these two swc-core versions.

You need to revert changes from this pull requests to make it work with 0.79.28 version:

#91
#79

Simply revert content of the rust files, no need to touch examples, readme, etc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Split macro support
4 participants