Add Prometheus Metrics Exporter #628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bai
approved these changes
May 6, 2020
|
Thanks for contributing! |
vazdauta
reviewed
Jul 21, 2020
|
|
||
| if consumerStatus == nil || | ||
| consumerStatus.Status == protocol.StatusNotFound || | ||
| consumerStatus.Complete < 1.0 { |
There was a problem hiding this comment.
I am wondering what is the reason for this particular rule( consumerStatus.Complete < 1.0 ).
We have some partitions that have the completion percentage 0.1. The cause of this seems to be related to the fact that we have some partitions that are empty and eventually - their offset expires(although I'm not sure - it might be something else on our side). The consequence is that the completion percentage for the consumer is less than 1 and it is not included in prometheus.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was wanting to export Burrow lag stats too Prometheus as we us it as our metrics and alerting platform. Im aware of a few exporters but didn't really want to run another service along side.
I noticed the PR (#537) and Issue (#318) this uses the general concept from the PR but uses the official Prometheus go client.