-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ensure existence of urn when calling BaseEntityResource::get #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce infrastructure for pre-update hooks, motivated by the need for a pre-update hook to remove duplicate elements from certain aspects.
keremsahin1
reviewed
Oct 19, 2021
restli-resources/src/main/java/com/linkedin/metadata/restli/BaseEntityResource.java
Show resolved
Hide resolved
jywadhwani
suggested changes
Oct 29, 2021
dao-impl/ebean-dao/src/main/java/com/linkedin/metadata/dao/EbeanLocalDAO.java
Show resolved
Hide resolved
restli-resources/src/main/java/com/linkedin/metadata/restli/BaseEntityResource.java
Show resolved
Hide resolved
restli-resources/src/main/java/com/linkedin/metadata/restli/BaseEntityResource.java
Show resolved
Hide resolved
RealChrisL
approved these changes
Nov 2, 2021
jywadhwani
reviewed
Nov 3, 2021
restli-resources/src/main/java/com/linkedin/metadata/restli/BaseEntityResource.java
Outdated
Show resolved
Hide resolved
jywadhwani
approved these changes
Nov 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
motivation: calling get() with an empty, non-null aspectNames parameter (i.e. []) results in a 404, even if the entity exists. the issue stems from the call to getInternalNonEmpty which filters out urn/aspect mappings where the value is empty (which it will be when aspectNames is empty). this results in calling get(0) on an empty map, which results in a 404.
the intended behavior should be:
urn doesn't exist - 404
urn exists -
* null aspects param - return all aspects
* empty aspects param - return base response with no aspects (i.e. only non-aspect fields)
this change checks that the urn exists in the db before calling one of the getInternal methods. additionally, because we do this exists check, we can now use getInternal instead of getInternalNonEmpty to get our intended behavior.
Checklist