[controller] Fix hybrid store migration failure during ongoing batch push jobs #1360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sushantmane
changed the title
majisourav99
reviewed
Dec 3, 2024
...s/venice-controller/src/main/java/com/linkedin/venice/controller/VeniceParentHelixAdmin.java
Outdated
Show resolved
Hide resolved
… ongoing batch push jobs This PR fixes an issue where hybrid store migration fails if a batch push job is ongoing and a non-truncated version topic exists in the parent region. The problem stemmed from a safeguard intended to prevent hybrid-to-batch conversion during ongoing push jobs (added to address targeted region push issues). The safeguard failed to account for store migration scenarios where hybrid configurations are added during the updateStore operation. This misclassification of the migration attempt as a batch-to-hybrid store conversion caused unintended operations, including a call to VPHA::getTopicForCurrentPushJob. This method attempts to issue a killOfflinePushJob when the version config is missing in the store’s configuration. The kill job, in turn, tries to update the version status to KILLED, which does not exist, which leads to a version not found exception from AbstractStore::updateVersionStatus.
sushantmane
force-pushed
the
li-fix-store-migration-issues
branch
from
f72497b to
280de65
Compare
majisourav99
approved these changes
Dec 3, 2024
|
Thank you, @smaji for the quick review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix hybrid store migration failure during ongoing batch push jobs
This PR fixes an issue where hybrid store migration fails if a batch push job is ongoing
and a non-truncated version topic exists in the parent region.
The problem stemmed from a safeguard intended to prevent hybrid-to-batch conversion during
ongoing push jobs (added to address targeted region push issues). The safeguard failed to
account for store migration scenarios where hybrid configurations are added during the
updateStore operation.
This misclassification of the migration attempt as a batch-to-hybrid store conversion
caused unintended operations, including a call to VPHA::getTopicForCurrentPushJob. This
method attempts to issue a killOfflinePushJob when the version config is missing in the
store’s configuration. The kill job, in turn, tries to update the version status to
KILLED, which does not exist, which leads to a version not found exception from
AbstractStore::updateVersionStatus.
Ref: #1143
How was this PR tested?
Does this PR introduce any user-facing changes?