Commits on Dec 3, 2024

1. [controller] Fix safeguard handling for hybrid store migration during… …

   … ongoing batch push
   
   jobs
   
   This PR fixes an issue where hybrid store migration fails if a batch push job is ongoing
   and a non-truncated version topic exists in the parent region.
   
   The problem stemmed from a safeguard intended to prevent hybrid-to-batch conversion during
   ongoing push jobs (added to address targeted region push issues). The safeguard failed to
   account for store migration scenarios where hybrid configurations are added during the
   updateStore operation.
   
   This misclassification of the migration attempt as a batch-to-hybrid store conversion
   caused unintended operations, including a call to VPHA::getTopicForCurrentPushJob. This
   method attempts to issue a killOfflinePushJob when the version config is missing in the
   store’s configuration. The kill job, in turn, tries to update the version status to
   KILLED, which does not exist, which leads to a version not found exception from
   AbstractStore::updateVersionStatus.

   

   sushantmane committed Dec 3, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for 3e6d0d3
   • Browse repository at this point

   Copy the full SHA

   3e6d0d3 View commit details

   Browse the repository at this point in the history

2. Address review comment

   

   sushantmane committed Dec 3, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for 280de65
   • Browse repository at this point

   Copy the full SHA

   280de65 View commit details

   Browse the repository at this point in the history