Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always enable identity in integration tests #1298

Merged
merged 1 commit into from
Oct 5, 2021
Merged

Always enable identity in integration tests #1298

merged 1 commit into from
Oct 5, 2021

Conversation

olix0r
Copy link
Member

@olix0r olix0r commented Oct 4, 2021

In preparation of making identity mandatory, this change adds
a default identity that is used in all integration tests (unless
overridden by the test itself).

This change also regenerates existing TLS credentials used in tests.

In preparation of making identity mandatory, this change adds
a default identity that is used in all integration tests (unless
overridden by the test itself).

This change also regenerates existing TLS credentials used in tests.
@olix0r olix0r requested a review from a team October 4, 2021 19:43
Copy link
Contributor

@hawkw hawkw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@@ -0,0 +1 @@
Some default secret token of some kind
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

love this, lol

Copy link
Member

@mateiidavid mateiidavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No comments. Great timing (for me) though, was hoping to get a chance to look into these a bit more closely.

@olix0r olix0r merged commit 4b3d4b8 into main Oct 5, 2021
@olix0r olix0r deleted the ver/tls-id-test branch October 5, 2021 15:35
olix0r added a commit to linkerd/linkerd2 that referenced this pull request Oct 7, 2021
This release updates the `h2` crate to support HTTP/2 messages with
large header values.

Legacy support for TLSv1.2 has been removed. Now the proxy only uses
TLSv1.3 for mTLS communication.  Also, gateway proxies now only support
clients that use the `transport.l5d.io` protocol, negotiated via ALPN.
With these changes, older clients (before ~v2.133.0) are no longer
supported by new servers.

---

* build(deps): bump libc from 0.2.102 to 0.2.103 (linkerd/linkerd2-proxy#1290)
* build(deps): bump trust-dns-resolver (linkerd/linkerd2-proxy#1291)
* build(deps): bump h2 from 0.3.4 to 0.3.6 (linkerd/linkerd2-proxy#1293)
* admin: Remove unused types (linkerd/linkerd2-proxy#1294)
* Remove use of TLS 1.2 (linkerd/linkerd2-proxy#1296)
* gateway: Require ALPN on gateway connections (linkerd/linkerd2-proxy#1297)
* Always enable identity in integration tests (linkerd/linkerd2-proxy#1298)
* tracing: use `Option`s as `tracing` values (linkerd/linkerd2-proxy#1299)
* build(deps): bump tracing-subscriber from 0.2.24 to 0.2.25 (linkerd/linkerd2-proxy#1300)
Pothulapati pushed a commit to linkerd/linkerd2 that referenced this pull request Oct 7, 2021
This release updates the `h2` crate to support HTTP/2 messages with
large header values.

Legacy support for TLSv1.2 has been removed. Now the proxy only uses
TLSv1.3 for mTLS communication.  Also, gateway proxies now only support
clients that use the `transport.l5d.io` protocol, negotiated via ALPN.
With these changes, older clients (before ~v2.133.0) are no longer
supported by new servers.

---

* build(deps): bump libc from 0.2.102 to 0.2.103 (linkerd/linkerd2-proxy#1290)
* build(deps): bump trust-dns-resolver (linkerd/linkerd2-proxy#1291)
* build(deps): bump h2 from 0.3.4 to 0.3.6 (linkerd/linkerd2-proxy#1293)
* admin: Remove unused types (linkerd/linkerd2-proxy#1294)
* Remove use of TLS 1.2 (linkerd/linkerd2-proxy#1296)
* gateway: Require ALPN on gateway connections (linkerd/linkerd2-proxy#1297)
* Always enable identity in integration tests (linkerd/linkerd2-proxy#1298)
* tracing: use `Option`s as `tracing` values (linkerd/linkerd2-proxy#1299)
* build(deps): bump tracing-subscriber from 0.2.24 to 0.2.25 (linkerd/linkerd2-proxy#1300)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants