Skip to content

Use WeakReference to avoid memory leaks in ArrayPool ThreadStatic field #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
konard wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Use WeakReference to avoid memory leaks in ArrayPool ThreadStatic field #163

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bd99479
Initial commit with task details for issue #99
konard Sep 13, 2025
6700158
Replace strong reference with WeakReference in ArrayPool ThreadStatic…
konard Sep 13, 2025
015fa6c
Remove CLAUDE.md - Claude command completed
konard Sep 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions csharp/Platform.Collections/Arrays/ArrayPool[T].cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,14 +24,26 @@ public class ArrayPool<T>
/// <para></para>
/// </summary>
[ThreadStatic]
private static ArrayPool<T> _threadInstance;
private static WeakReference<ArrayPool<T>> _threadInstance;
/// <summary>
/// <para>
/// Gets the thread instance value.
/// </para>
/// <para></para>
/// </summary>
internal static ArrayPool<T> ThreadInstance => _threadInstance ?? (_threadInstance = new ArrayPool<T>());
internal static ArrayPool<T> ThreadInstance
{
get
{
if (_threadInstance?.TryGetTarget(out var instance) == true)
{
return instance;
}
var newInstance = new ArrayPool<T>();
_threadInstance = new WeakReference<ArrayPool<T>>(newInstance);
return newInstance;
}
}
private readonly int _maxArraysPerSize;
private readonly Dictionary<long, Stack<T[]>> _pool = new Dictionary<long, Stack<T[]>>(ArrayPool.DefaultSizesAmount);

Expand Down
Loading