Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Travis errors - karma and mocha #267

Merged
merged 3 commits into from
Feb 17, 2014
Merged

Conversation

fyockm
Copy link
Contributor

@fyockm fyockm commented Feb 7, 2014

A few things:

  • as in Fix karma.conf.js for missing angular-ui-utils error #245, path for angular-ui-utils required update in karma.conf
  • unit test failed because of missing linkedin config for test env
  • last user model unit test failed because provider must be set for validation to occur, and simplified
  • Gruntfile still had reference to jade - merged path with existing html task
  • Gruntfile - excluded test/coverage from jshint

bbaaxx added a commit to bbaaxx/utingen that referenced this pull request Feb 7, 2014
@bbaaxx
Copy link

bbaaxx commented Feb 8, 2014

Just a note: The unit test for the user model is being addressed by #240

@fyockm
Copy link
Contributor Author

fyockm commented Feb 9, 2014

I think you mean #242, but it also includes a breaking change to package.json. And I didn't notice that one before submitting mine. I noticed the Travis issues when submitting a previous PR and decided to fix them.

Looking through past PRs now, I see that this one is basically a combination of #242, #245, #262, and #265, plus some other fixes.

@liorkesos liorkesos merged commit 96e91dc into linnovate:master Feb 17, 2014
@fyockm
Copy link
Contributor Author

fyockm commented Feb 17, 2014

👍 Thanks for merging!

@liorkesos
Copy link
Member

Thanks for the help in the issue queue - did you see the new site?

On Mon, Feb 17, 2014 at 10:32 PM, Drew Fyock notifications@github.comwrote:

[image: 👍] Thanks for merging!

Reply to this email directly or view it on GitHubhttps://github.com//pull/267#issuecomment-35320116
.

Lior Kesos - http://www.linnovate.net
Linnovate - Community Infrastructure Care
mail: lior@linnovate.net
office: +972 722500881
cell: +972 524305252
skype: liorkesos

@fyockm
Copy link
Contributor Author

fyockm commented Mar 11, 2014

New site looks great! I like the FAQ section (currently on the Documentation page), since we often get these questions. However, I think it might make more sense to be called "Troubleshooting" and live on the Support page?

@liorkesos
Copy link
Member

Good idea... I'll move it there.

sarareisner pushed a commit to liorkesos/mean that referenced this pull request Mar 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants