test: Add e2e test framework and update makefile and GHA workflow #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # builder/linode/config_test.go
ykim-akamai
requested review from
jriddle-linode and
vshanthe
and removed request for
a team
|
Here is a green build on my forked repo - https://github.com/ykim-1/packer-plugin-linode/actions/runs/7659265343 |
jriddle-linode
approved these changes
Jan 26, 2024
|
As discussed privately, we may want to have a way to specify the image name and clean it up after tests.
|
|
@zliang-akamai good catch! Just added the teardown |
zliang-akamai
approved these changes
Jan 31, 2024
|
And don't forget fix the lint 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
This PR adds a few things:
✔️ How to Test
make unit-test
make int-test
make test (Tests all the test in the repo)