Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Helper Sub-Package #208

Merged
merged 5 commits into from
Mar 25, 2024

Conversation

zliang-akamai
Copy link
Member

@zliang-akamai zliang-akamai commented Mar 20, 2024

📝 Description

Wrapping up some reusable utilities into helper sub-package for future dev work on data sources and post-processors.

Testing

Manual Test

Place this content below into a file called test.pkr.hcl.

data "linode-image" "latest_ubuntu" {
    id_regex = "linode/ubuntu.*"
    latest = true
}

source "linode" "example" {
  image             = linode-image.latest_ubuntu.id
  image_description = "My Private Image"
  image_label       = "my-packaer-private-linode-image-test"
  instance_label    = "temporary-linode-image"
  instance_type     = "g6-nanode-1"
  region            = "us-mia"
  ssh_username      = "root"
}

build {
  sources = ["source.linode.example"]
}

Run build command

packer build .

Automated Test

make test

@zliang-akamai zliang-akamai requested a review from a team as a code owner March 20, 2024 05:23
@zliang-akamai zliang-akamai requested review from lgarber-akamai and ykim-akamai and removed request for a team March 20, 2024 05:23
Copy link
Contributor

@lgarber-akamai lgarber-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds as expected locally, nice refactor!

Copy link
Contributor

@ykim-akamai ykim-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zliang-akamai zliang-akamai merged commit d1035ed into linode:dev Mar 25, 2024
9 checks passed
@zliang-akamai zliang-akamai deleted the zhiwei/helper-package branch March 25, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants