generated from hashicorp/packer-plugin-scaffolding
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Linode Image Data Source #209
Merged
zliang-akamai
merged 13 commits into
linode:dev
from
zliang-akamai:zhiwei/linode-image-data-source
Mar 28, 2024
Merged
Implement Linode Image Data Source #209
zliang-akamai
merged 13 commits into
linode:dev
from
zliang-akamai:zhiwei/linode-image-data-source
Mar 28, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zliang-akamai
requested review from
jriddle-linode and
yec-akamai
and removed request for
a team
March 20, 2024 05:51
zliang-akamai
changed the title
Zhiwei/linode image data source
Implement Linode Image Data Source
Mar 20, 2024
zliang-akamai
force-pushed
the
zhiwei/linode-image-data-source
branch
2 times, most recently
from
March 20, 2024 06:47
2e7e971
to
3dcd769
Compare
zliang-akamai
force-pushed
the
zhiwei/linode-image-data-source
branch
from
March 20, 2024 06:51
3dcd769
to
5f53cf9
Compare
lgarber-akamai
approved these changes
Mar 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests are all passing locally and everything seems to be working well in my local testing (dx-devenv), excellent work!
yec-akamai
approved these changes
Mar 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works well on my end. Nice work!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Built on top of #208. If we can merge #208 before this PR and then rebase this branch, the number of changed lines in this PR may be reduced.
TODO:
Needs next linodego release containing linode/linodego@73f38b5doneUnit/integration test implementation is in progressdone✔️ How to Test
Automated Test
make test
Manual Test
Build packer plugin locally.
Place this content below into a file call
test.pkr.hcl
.Run build command
packer build .
Verify the config on the test Linode is called
My Ubuntu 23.10
, meaning the latest Ubuntu was selected.You can also switch image output from other 2 data sources and verify the config name accordingly.