Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the version and source references for examples in documentation. #35

Merged
merged 6 commits into from Jan 19, 2022
Merged

Fix the version and source references for examples in documentation. #35

merged 6 commits into from Jan 19, 2022

Conversation

ghost
Copy link

@ghost ghost commented Jan 19, 2022

  • fixes the plugin source (from github.com/hashicorp/linode to github.com/hashicorp/packer-plugin-linode) in example
  • bumped the version in the example since 1.0.1 is the latest release

- fixes the plugin source (from github.com/hashicorp/linode to github.com/hashicorp/packer-plugin-linode
- bumped the version in the example since `1.0.1` is the latest release
@ghost ghost self-requested a review as a code owner January 19, 2022 04:04
@hashicorp-cla
Copy link

hashicorp-cla commented Jan 19, 2022

CLA assistant check
All committers have signed the CLA.

@ghost ghost changed the title update basic_linode.pkr.hcl example Fix the version and source references for examples in documentation. Jan 19, 2022
Copy link
Contributor

@nywilken nywilken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the documentation to use the latest version. There is a small issue with the updated source reference that needs to be addressed before we can merge.

I left a detailed comment around the suggested change. Please let us know if you have any questions.

docs/README.md Outdated Show resolved Hide resolved
docs/builders/linode.mdx Outdated Show resolved Hide resolved
example/basic_linode.pkr.hcl Outdated Show resolved Hide resolved
Gordias and others added 3 commits January 19, 2022 11:05
Co-authored-by: Wilken Rivera <dev@wilkenrivera.com>
Co-authored-by: Wilken Rivera <dev@wilkenrivera.com>
Co-authored-by: Wilken Rivera <dev@wilkenrivera.com>
@ghost ghost requested a review from nywilken January 19, 2022 16:06
@ghost
Copy link
Author

ghost commented Jan 19, 2022

Changes applied, thank you!

Copy link
Contributor

@nywilken nywilken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nywilken nywilken merged commit c3d7806 into linode:main Jan 19, 2022
@ghost ghost deleted the patch-1 branch January 19, 2022 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants