Skip to content

Commit 3bb9b0a

Browse files
Alex Williamsongregkh
authored andcommitted
vfio/pci: Clear error and request eventfd ctx after releasing
[ Upstream commit 5c5866c ] The next use of the device will generate an underflow from the stale reference. Cc: Qian Cai <cai@lca.pw> Fixes: 1518ac2 ("vfio/pci: fix memory leaks of eventfd ctx") Reported-by: Daniel Wagner <dwagner@suse.de> Reviewed-by: Cornelia Huck <cohuck@redhat.com> Tested-by: Daniel Wagner <dwagner@suse.de> Signed-off-by: Alex Williamson <alex.williamson@redhat.com> Signed-off-by: Sasha Levin <sashal@kernel.org>
1 parent 781a4bf commit 3bb9b0a

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

drivers/vfio/pci/vfio_pci.c

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -474,10 +474,14 @@ static void vfio_pci_release(void *device_data)
474474
if (!(--vdev->refcnt)) {
475475
vfio_spapr_pci_eeh_release(vdev->pdev);
476476
vfio_pci_disable(vdev);
477-
if (vdev->err_trigger)
477+
if (vdev->err_trigger) {
478478
eventfd_ctx_put(vdev->err_trigger);
479-
if (vdev->req_trigger)
479+
vdev->err_trigger = NULL;
480+
}
481+
if (vdev->req_trigger) {
480482
eventfd_ctx_put(vdev->req_trigger);
483+
vdev->req_trigger = NULL;
484+
}
481485
}
482486

483487
mutex_unlock(&vdev->reflck->lock);

0 commit comments

Comments
 (0)