Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

popupMenu.js: Simplify the menu animation #12405

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

JosephMcc
Copy link
Contributor

Currently the menu animates a distance of 1/10 the menus height/width. This leads to some menus having a bit different animation then others. Switch to using a hard coded distance instead. With the smaller distance we can also now remove the set_clip() that is being used. That hurts performance, especially on HiDpi. That was being updated on every update of the tween. It also clips out any box shadow that the theme is using on the menu as a side effect.

With the smaller amount of translation happening in the menu, slow down the speed of the animation just a bit. This results in the overall animation looking very similar to how it did before.

Currently the menu animates a distance of 1/10 the menus height/width. This
leads to some menus having a bit different animation then others. Switch to
using a hard coded distance instead. With the smaller distance we can also
now remove the set_clip() that is being used. That hurts performance,
especially on HiDpi. That was being updated on every update of the tween.
It also clips out any box shadow that the theme is using on the menu as a
side effect.

With the smaller amount of translation happening in the menu, slow down the
speed of the animation just a bit. This results in the overall animation
looking very similar to how it did before.
@mtwebster mtwebster merged commit 2b4a028 into linuxmint:master Nov 18, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants