Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make readme more clear on use, update changelog #66

Merged
merged 2 commits into from
Oct 14, 2023
Merged

Conversation

drizuid
Copy link
Member

@drizuid drizuid commented Oct 14, 2023

linuxserver.io


  • [X ] I have read the contributing guideline and understand that I have made the correct modifications

Description:

Add some notes on what the SUBDOMAINS var needs to contain as it is confusing.

Benefits of this PR and context:

reduce our support burden by more clearly explaining the var

How Has This Been Tested?

N/A

Source / References:

https://discord.com/channels/354974912613449730/506828136869265408/1162789772952076288

@LinuxServer-CI
Copy link
Contributor

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/duckdns/256b24bf-pkg-256b24bf-dev-6f8d779a3f65e0fd3ff0436700c69adb1216adfc-pr-66/index.html
https://ci-tests.linuxserver.io/lspipepr/duckdns/256b24bf-pkg-256b24bf-dev-6f8d779a3f65e0fd3ff0436700c69adb1216adfc-pr-66/shellcheck-result.xml

Tag Passed
amd64-256b24bf-pkg-256b24bf-dev-6f8d779a3f65e0fd3ff0436700c69adb1216adfc-pr-66
arm64v8-256b24bf-pkg-256b24bf-dev-6f8d779a3f65e0fd3ff0436700c69adb1216adfc-pr-66

@drizuid drizuid requested a review from a team October 14, 2023 16:45
@drizuid drizuid merged commit 9891a49 into master Oct 14, 2023
4 checks passed
@drizuid drizuid deleted the drizuid-patch-1 branch October 14, 2023 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants