chore(DAT-19084): we should always attach source, unless it's a pro extension that uses pro-guard

[filipelautert]

chore: we should always attach source, unless it's a pro extension that uses pro-guard

[StevenMassaro]

This looks like it does the opposite, attaching sources only if the run-proguard profile is activated. Am I misreading it?

Also - won't maven central reject the submission if we don't supply a jar with some kind of sources and readme?

[filipelautert]

This looks like it does the opposite, attaching sources only if the run-proguard profile is activated. Am I misreading it?

Also - won't maven central reject the submission if we don't supply a jar with some kind of sources and readme?

@StevenMassaro with this PR it is running the default attach sources if run-proguard is not specified;
and if it's pro-guard it runs the custom execution, that only attaches the readme.sources.txt files. In the custom execution it uses the include tag , and if you include something everything else is ignored.

Right now the custom execution is being activated for everyone, thus generating empty sources.jar files as no readme.sources.txt is available in OSS extensions.

[KushnirykOleh]

i had to disable those 2 executions to get sources and javadoc jars, as otherwise jar plugin was overriding what other plugins created.
liquibase/liquibase-databricks#219
So for me it seems like legit fix - don't try to put readme.javadocs.txt in sources and javadoc jars for normal executions