Use LiquibaseMojo as implemention class. Include Pro commands in plugin.xml DAT-12158 #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also include Pro commands in list of possible goals DAT-12158
StevenMassaro
approved these changes
Nov 18, 2022
| pluginXml.appendChild(pluginElement); | ||
|
|
||
| addNode("name", "liquibase-maven-plugin", pluginElement, pluginXml); | ||
| addNode("description", "A Maven plugin wraps up some of the functionality of Liquibase", pluginElement, pluginXml); |
There was a problem hiding this comment.
Probably should change the description now:
Suggested change
| addNode("description", "A Maven plugin wraps up some of the functionality of Liquibase", pluginElement, pluginXml); | |
| addNode("description", "A Maven plugin wraps up the functionality of Liquibase", pluginElement, pluginXml); |
Comment on lines
+27
to
+28
| @Mojo(name = "build-plugin-xml") | ||
| public class BuildPluginXmlMojo extends AbstractMojo { |
There was a problem hiding this comment.
Please add some javadoc to this class that explains what it does.
nvoxland
approved these changes
Nov 18, 2022
|
@StevenMassaro and @wwillard7800 - is this PR ready to merge? |
This could be merged, I suppose, but I don't think it should be. It's a new feature for generating the maven plugin in a different way, but it's not currently used anywhere. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The build-plugin-xml goal builds the plugin.xml which the Maven plugin uses. There is now a new LiquibaseMojo implementation class which simplifies handling of the goal and the command it executes.