Miscellaneous repo cleanup #560
Conversation
|
A live preview of this PR will be available at the URL(s) below. https://pr560-d136940---lit-dev-5ftespv5na-uc.a.run.app/ |
aomarks
force-pushed
the
integration-tests-wip
branch
4 times, most recently
from
a66584d to
d136940
Compare
There was a problem hiding this comment.
Checked in the code and tried some test, build and format commands. Also skimmed some of the preview url. Not 100% sure where the risky areas are but from some random feature checking everything is working.
This cleanup is fantastic. Great formatting and factoring. Also thank you for attaching those search tests to the CI.
A little unsure why one of the CI checks is stuck on the build.
Apart from that this is a huge improvement! LGTM!
| - if: ${{ always() && steps.test.outcome == 'failure' }} | ||
| run: npm run test:integration:update-golden-screenshots | ||
|
|
||
| - if: ${{ always() && steps.test.outcome == 'failure' }} |
| "test:integration:install-deps": "npx playwright install-deps chromium", | ||
| "test:integration:run": "npx playwright test", | ||
| "test:integration:update-golden-screenshots": "npx playwright test --update-snapshots" | ||
| "test:unit": "lerna run test --scope lit-dev-tools-cjs --scope lit-dev-tools-esm", |
There was a problem hiding this comment.
This was a bug - sorry! Good find and fix! Thank you!
aomarks
force-pushed
the
integration-tests-wip
branch
from
5ee8310 to
f2e924b
Compare
Fixes a regression from #560 where we accidentally dropped from "target": "esnext" to "target": "es2020" in the tsconfig.json for sample files (I made a common tsconfig.base.json which defaults to es2020 but forgot to override that in the samples one). We want esnext output for samples because we want to emit standard static class fields (note that @lit/ts-transformers switches instance class field initializers to be constructor-initialized if they are decorated with @Property, to avoid that incompatibility).
lit-dev-testspackage because:playground-pluginunit tests in CI (under newtest:unitgrouping).integration-testsaction, but only run it if the tests fail.webServerfeature instead ofrun-pto launch the server used for integration testing.lit-dev-toolstolit-dev-tools-cjsto distinguish it fromlit-dev-tools-esm.manropefont download step if it hasn't already run (it was needlessly running every time we installed anything or bootstrapped through lerna)tsconfig.base.json.