Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ask all the "optional" questions before beginning to install plugins #101

Open
Guldoman opened this issue Mar 21, 2024 · 4 comments
Open

Comments

@Guldoman
Copy link
Member

For example at the moment if someone leaves the terminal while a download is in progress, they might get back to a prompt that will trigger another download.

@adamharrison
Copy link
Member

This is complicated, as there could be a chain of these, and I'd have to rearchitect how it fetches things. Realistically, we don't know whether we need to fetch the dependencies of something until you ask to install it. If those dependencies have optional dependencies, we have to recursively fetch all that. We can do it, but it'd likely mean huge chains of downloads for not necessarily a good reason.

@Guldoman
Copy link
Member Author

Can we get the ones for the already fetched repos in a reasonable manner?

@adamharrison
Copy link
Member

Probably a lot easier, yeah. I'd be OK with that, I suppose.

@Guldoman
Copy link
Member Author

I was thinking, what if you only delay files downloads?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants