add cors origin validation for portal server and auth server #4725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shovan Maity <shovan.maity@harness.io>
imrajdas
approved these changes
Jun 24, 2024
Signed-off-by: Shovan Maity <shovan.maity@harness.io>
Signed-off-by: Shovan Maity <shovan.cse91@gmail.com>
SarthakJain26
approved these changes
Jun 24, 2024
amityt
approved these changes
Jun 24, 2024
Signed-off-by: Shovan Maity <shovan.maity@harness.io>
Jonsy13
approved these changes
Jun 24, 2024
Jonsy13
reviewed
Jun 24, 2024
shovanmaity
changed the title
andoriyaprashant
pushed a commit
to andoriyaprashant/litmus
that referenced
this pull request
Sep 7, 2024
* add cors check Signed-off-by: Shovan Maity <shovan.maity@harness.io> * add cors check custom middleware Signed-off-by: Shovan Maity <shovan.maity@harness.io> * change default url Signed-off-by: Shovan Maity <shovan.maity@harness.io> --------- Signed-off-by: Shovan Maity <shovan.maity@harness.io> Signed-off-by: Shovan Maity <shovan.cse91@gmail.com> Signed-off-by: andoriyaprashant <prashantandoriya@gmail.com>
andoriyaprashant
pushed a commit
to andoriyaprashant/litmus
that referenced
this pull request
Sep 7, 2024
* add cors check Signed-off-by: Shovan Maity <shovan.maity@harness.io> * add cors check custom middleware Signed-off-by: Shovan Maity <shovan.maity@harness.io> * change default url Signed-off-by: Shovan Maity <shovan.maity@harness.io> --------- Signed-off-by: Shovan Maity <shovan.maity@harness.io> Signed-off-by: Shovan Maity <shovan.cse91@gmail.com> Signed-off-by: andoriyaprashant <prashantandoriya@gmail.com>
sagnik3788
pushed a commit
to sagnik3788/litmus
that referenced
this pull request
Oct 5, 2024
* add cors check Signed-off-by: Shovan Maity <shovan.maity@harness.io> * add cors check custom middleware Signed-off-by: Shovan Maity <shovan.maity@harness.io> * change default url Signed-off-by: Shovan Maity <shovan.maity@harness.io> --------- Signed-off-by: Shovan Maity <shovan.maity@harness.io> Signed-off-by: Shovan Maity <shovan.cse91@gmail.com> Signed-off-by: sagnik3788 <116512372+sagnik3788@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds cors origin validation for portal server and auth server.
As frontend communicates with portal server and auth server using internal service fqdn and user access the portal using public url both are added in allowed list