Only return the neccessary info using maple --number option #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Return: - total filtered number. - top N items' text as well as their fuzzy indices.
Merged
liuchengxu
pushed a commit
that referenced
this pull request
Aug 17, 2021
Doter's milestone 1 delivery
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR, the async job only returns the minimal info we care if you are using maple:
This PR mostly resolves the performance issue in #140 , at least vim should be able to keep responsive even when you search at scale, except the initial forerunner job caching:
vim-clap/autoload/clap/forerunner.vim
Line 36 in 4df7d68
Writing 1 million lines to a tmp file costs 5 seconds on my machine, which becomes the main bottleneck once this PR is merged. The good news is that this writing happens only once per vim-clap session and I can move this heavy job into the maple extension later.