Resolve async job perf #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…resolve-async-job-perf
…resolve-async-job-perf
liuchengxu
pushed a commit
that referenced
this pull request
Aug 17, 2021
instead of asking for the PR, get the application document itself
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of #181: fix the slowness of wirting 1 million lines into a tempfile inside vim when caching the forerunner job result.
Aftre this PR, the only performance issue of async is during the time of forerunner job not finished yet, which can be optimized further later using
--cmdof maple. Once the forerunner job is done, you can smoothly search/filter 1 million items.