[pull] master from airbnb:master #41
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
This rule was deprecated since ESLint v3.3.0 and replaced by the `func-call-spacing` rule. https://eslint.org/docs/latest/rules/no-spaced-func `func-call-spacing` was enabled in this package long ago: 27dcb99 So there's no need for it to stay in the ruleset. Besides, it is causing some tricky issues when overriding the rules for TypeScript support (iamturns/eslint-config-airbnb-typescript#246)
…n-react`, `eslint-plugin-react-hooks`
2.1 Use const for all of your references; avoid using var. eslint: prefer-const, no-const-assign
The change itself has already been made in f3d3a07 (tracked in/acording to #2421 (comment)). #2421 Remove Math.pow from `no-restricted-properties` and use `prefer-exponentiation-operator` instead.
phuc-hoang-39
approved these changes
May 13, 2023
Co-authored-by: Jordan Harband <ljharb@gmail.com>
The recommendation is to declare the variables, classes and functions before. So the contrasting negative example should say after.
This removes the `object.entries` package and uses the widely available built-in native `Object.entries`.
…expression values
… have `navigation` role
Signed-off-by: Kim Minh Thắng <thangved02@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )