From d8e640cef6b4c898a4daa6f183de798d60b1a955 Mon Sep 17 00:00:00 2001 From: Jordan Harband Date: Sat, 8 Jul 2023 12:00:05 -0700 Subject: [PATCH] bootstrap: use correct descriptor for Symbol.{dispose,asyncDispose} Followup to #48518; fixes #48699 --- lib/internal/process/pre_execution.js | 21 +++++++++++++++++++-- 1 file changed, 19 insertions(+), 2 deletions(-) diff --git a/lib/internal/process/pre_execution.js b/lib/internal/process/pre_execution.js index cab2eacb8c0723..54258c572c07f6 100644 --- a/lib/internal/process/pre_execution.js +++ b/lib/internal/process/pre_execution.js @@ -128,9 +128,26 @@ function prepareExecution(options) { function setupSymbolDisposePolyfill() { // TODO(MoLow): Remove this polyfill once Symbol.dispose and Symbol.asyncDispose are available in V8. // eslint-disable-next-line node-core/prefer-primordials - Symbol.dispose ??= SymbolDispose; + if (typeof Symbol.dispose !== 'symbol') { + ObjectDefineProperty(Symbol, 'dispose', { + __proto__: null, + configurable: false, + enumerable: false, + value: SymbolDispose, + writable: false, + }); + } + // eslint-disable-next-line node-core/prefer-primordials - Symbol.asyncDispose ??= SymbolAsyncDispose; + if (typeof Symbol.asyncDispose !== 'symbol') { + ObjectDefineProperty(Symbol, 'asyncDispose', { + __proto__: null, + configurable: false, + enumerable: false, + value: SymbolAsyncDispose, + writable: false, + }); + } } function setupUserModules(isLoaderWorker = false) {